ilObjStudyProgrammeSettingsGUI

• The settings form currently performs side effects in the transformation of the form. This is not allowed and thus needs to be removed. We could use the data objects from the models instead and simply set a new settings object to the programme object.
• Remove inline html from GUI's.
• Replace the default -1 value with null in prg_sttings
• Refactoring of DIC. Split in multiple DIC with object or without. Perhaps it is possible to switch to trait
• Remove all setObject and getObject Methods in classes
• Refactoring subtab structure for settings
• Refactoring subtab structure for settings

ilObjStudyProgrammeSettings

• There is an outdated an unnecessary cache implementation that sould be removed

ilStudyProgrammeIndividualPlanTableGUI

• fetchData passes a reference to $plan into applyToSubTreeNodes; this is quite implicit and might be amended by a catamorphic "requestFromSubTreeNodes"?!

Construction of ilStudyProgrammeAssignment and ilStudyProgrammeProgress

• "Correctness by Construction": The properies should go in the constructor of the classes; maybe we can also get rid of one or the other mutator?

Assignment/Progress

There are properties on assignment/progress, that look like misconceptions and should move. Careful: This also means migrating! * Deadline and validity of qualification both belong to Assignment (not Progress) * AssignmentDate belongs to Assignment (not Progress) * Relevant/Irrelevant is not a status, but a separate flag. * "Completion of Assignment/Qualification" means: progress at root-node is successful. * "Individual" rather belongs to Assignemnt and says: there are modifications to progresses in terms of points or relevance. This is not a static flag but a result of querying progresses.

ilStudyProgrammeTypeDBRepository

• The method getStudyProgrammeIdsByTypeId is unnecessarily slow, we could only load ids instead of getting them from complete settings objects.

ilObjStudyProgrammeMembersGUI / ilPRGAssignmentFilter

• There are sorting and range options in the GUI that saould move to the Filter.

ilObjStudyProgramme

• The query whether there are relevant progresses (canBeRemoved) should go into the repo and target progresses(-count) directly.

ilPRGAssignmentDBRepository

• ilStudyProgrammeAppEventListener::onServiceUserDeleteUser reads assignments only to delete them. Delete immediadetely.
• remove interimOrguLookup as soon as ilObjUser::lookupOrgUnitsRepresentation is working correctly

Events

• ilStudyProgrammeAppEventListener handles "internal" events, such as userReAssigned, informUserToRestart or userRiskyToFail; those should not be piped over the event system, but can be dealt with in ilStudyProgrammeEvents/PRGEventHandler.